Skip to content

[NUI] Remove NUI.Wearable by TCSACR-648#7581

Open
dongsug-song wants to merge 1 commit intoSamsung:DevelNUIfrom
dongsug-song:develnui-0421
Open

[NUI] Remove NUI.Wearable by TCSACR-648#7581
dongsug-song wants to merge 1 commit intoSamsung:DevelNUIfrom
dongsug-song:develnui-0421

Conversation

@dongsug-song
Copy link
Copy Markdown
Contributor

Description of Change

[NUI] Remove NUI.Wearable by TCSACR-648

API Changes

https://jira.sec.samsung.net/browse/TCSACR-648

@TizenAPI-Bot
Copy link
Copy Markdown
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 33, Changed: 0

Removed

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.Window Tizen.NUI.NUIWatchApplication::Window()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::.ctor()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::.ctor(System.String)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::Exit()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAmbientChanged(Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs)

- /// <privilege>http://tizen.org/privilege/alarm.set</privilege
- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAmbientTick(Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAppControlReceived(Tizen.Applications.AppControlReceivedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnCreate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLocaleChanged(Tizen.Applications.LocaleChangedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLowBattery(Tizen.Applications.LowBatteryEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLowMemory(Tizen.Applications.LowMemoryEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnPause()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnPreCreate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnRegionFormatChanged(Tizen.Applications.RegionFormatChangedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnResume()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnTerminate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnTimeTick(Tizen.NUI.NUIWatchApplication/TimeTickEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::Run(System.String[])

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::AmbientChanged

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::AmbientTick

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::Paused

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::Resumed

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::TimeTick

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs::Changed()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs::.ctor(System.Boolean)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.WatchTime Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs::WatchTime()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs::.ctor(Tizen.NUI.WatchTime)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/TimeTickEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.WatchTime Tizen.NUI.NUIWatchApplication/TimeTickEventArgs::WatchTime()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/TimeTickEventArgs::.ctor(Tizen.NUI.WatchTime)

Internal API Changed

Added: 0, Removed: 251, Changed: 0

@TizenAPI-Bot
Copy link
Copy Markdown
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 33, Changed: 0

Removed

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.Window Tizen.NUI.NUIWatchApplication::Window()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::.ctor()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::.ctor(System.String)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::Exit()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAmbientChanged(Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs)

- /// <privilege>http://tizen.org/privilege/alarm.set</privilege
- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAmbientTick(Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnAppControlReceived(Tizen.Applications.AppControlReceivedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnCreate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLocaleChanged(Tizen.Applications.LocaleChangedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLowBattery(Tizen.Applications.LowBatteryEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnLowMemory(Tizen.Applications.LowMemoryEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnPause()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnPreCreate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnRegionFormatChanged(Tizen.Applications.RegionFormatChangedEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnResume()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnTerminate()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::OnTimeTick(Tizen.NUI.NUIWatchApplication/TimeTickEventArgs)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication::Run(System.String[])

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::AmbientChanged

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::AmbientTick

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::Paused

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::Resumed

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.EventHandler Tizen.NUI.NUIWatchApplication::TimeTick

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Boolean Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs::Changed()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/AmbientChangedEventArgs::.ctor(System.Boolean)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.WatchTime Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs::WatchTime()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/AmbientTickEventArgs::.ctor(Tizen.NUI.WatchTime)

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.NUIWatchApplication/TimeTickEventArgs

- /// <since_tizen>none</since_tizen
- [Obsolete]
- Tizen.NUI.WatchTime Tizen.NUI.NUIWatchApplication/TimeTickEventArgs::WatchTime()

- /// <since_tizen>none</since_tizen
- [Obsolete]
- System.Void Tizen.NUI.NUIWatchApplication/TimeTickEventArgs::.ctor(Tizen.NUI.WatchTime)

Internal API Changed

Added: 0, Removed: 251, Changed: 0

@JoonghyunCho
Copy link
Copy Markdown
Member

🤖 [AI Review]
🟡 Cleanup — a few leftover references to the removed assembly that should be scrubbed:

  1. Orphan project-config GUID in both .sln files. The Project(…) declaration was removed, but the configuration rows for {A2B607F9-5B9B-43AC-A8CA-E0FDF2A6694E} remain and now point at nothing:

    • test/Tizen.NUI.LayoutSamples/Tizen.NUI.LayoutSamples.sln lines 92-95
    • test/Tizen.NUI.Samples/Tizen.NUI.Samples.sln lines 94-97
  2. Stale InternalsVisibleTo in src/Tizen.NUI/src/internal/Common/FriendAssembly.cs:27:

[assembly: InternalsVisibleTo("Tizen.NUI.Wearable, " + Tizen.NUI.PublicKey.TizenFX)]

This line should be removed since the assembly no longer exists.


Automated review by AI assistant

Copy link
Copy Markdown
Member

@wiertel wiertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of Obsolete marked API - this is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants